feat: set default tf & conftest env vars for apline #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moogly81
changed the title
moogly81
changed the title
moogly81
force-pushed
the
align-env-vars
branch
from
8f6e7c4
to
3081de6
Compare
|
@moogly81 can you fix the conflicts? Thanks. |
moogly81
force-pushed
the
align-env-vars
branch
from
3081de6
to
85e3877
Compare
moogly81
force-pushed
the
align-env-vars
branch
from
85e3877
to
5f622fe
Compare
|
Done |
jamengual
approved these changes
Oct 6, 2023
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Allow DEFAULT_CONFTEST_VERSION and DEFAULT_TERRAFORM_VERSION in alpine image * update go image to pass build test --------- Co-authored-by: Damien Sonney <dsonney@pictet.com>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Allow DEFAULT_CONFTEST_VERSION and DEFAULT_TERRAFORM_VERSION in alpine image * update go image to pass build test --------- Co-authored-by: Damien Sonney <dsonney@pictet.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
In the Alpine Docker image, those 2 variables are not available, but they are available in the ubuntu version :
DEFAULT_CONFTEST_VERSION
DEFAULT_TERRAFORM_VERSION
why
Some have expressed the need to use the DEFAULT_TERRAFORM_VERSION and DEFAULT_CONFTEST_VERSION in the alpine image. Right now, we're rebuilding the image to include this environment variable.
tests
I have tested my changes by building locally