Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Merge depends-on.md into repo-level-atlantis-yaml.md #3823

Closed

Conversation

vincentgna
Copy link
Contributor

@vincentgna vincentgna commented Oct 6, 2023

Previously the depends-on.md was missing from runatlantis.io/.vuepress/config.js and unreachable on the docs website.

With this PR, the docs are added into the "Order of planning/applying" section and the example is updated based on #3292 discussion.

Docs Preview:
https://deploy-preview-3823--runatlantis.netlify.app/docs/repo-level-atlantis-yaml.html#order-of-planning-applying

Previously the `depends-on.md` was missing from `runatlantis.io/.vuepress/config.js` and unreachable on the docs website.

With this PR, the docs are added into the "Order of planning/applying" section and the example is updated based on runatlantis#3292 discussion.
@vincentgna vincentgna requested a review from a team as a code owner October 6, 2023 14:51
@github-actions github-actions bot added the docs Documentation label Oct 6, 2023
@vincentgna
Copy link
Contributor Author

@Luay-Sol - I used your example from the PR discussion instead as I think it explained the feature better, feel free to suggest changes.

Copy link
Member

@GenPage GenPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, can we surface the the differences between the two a bit more, maybe with some small headings?

@vincentgna vincentgna marked this pull request as draft October 6, 2023 15:14
@jamengual
Copy link
Contributor

PR #3292 was reverted, but I will leave this open in case @vincentgna @Luay-Sol can brainstorm and fix the bug on the feature.

@vincentgna vincentgna closed this Mar 18, 2024
@vincentgna vincentgna deleted the fix-project-depends-on-docs branch March 18, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants