Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new mergeable requirement #388

Merged
merged 6 commits into from Dec 12, 2018
Merged

Introduce new mergeable requirement #388

merged 6 commits into from Dec 12, 2018

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Dec 12, 2018

Introduce new mergeable requirement, in similar vein to the approved
requirement.

Fixes #43.

Notes:

Brenden Matthews and others added 6 commits December 11, 2018 16:00
Introduce new `mergeable` requirement, in similar vein to the `approved`
requirement. Ran `make go-generate` to update mocks accordingly.

This addresses issue #43.
- Need to use the mergeable_state field in GitHub to know if a pull
request is mergeable.
- Add tests.
- Since we updated our vendored go-github library, fix how we were
creating webhooks in testdrive.
@codecov
Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #388 into master will decrease coverage by 0.6%.
The diff coverage is 36.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   70.37%   69.77%   -0.61%     
==========================================
  Files          62       62              
  Lines        3743     3801      +58     
==========================================
+ Hits         2634     2652      +18     
- Misses        922      960      +38     
- Partials      187      189       +2
Impacted Files Coverage Δ
cmd/server.go 79.16% <ø> (ø) ⬆️
testdrive/github.go 0% <ø> (ø) ⬆️
server/events/vcs/bitbucketcloud/client.go 41.02% <0%> (-5.13%) ⬇️
server/events/vcs/proxy.go 30.76% <0%> (-2.57%) ⬇️
server/events/vcs/not_configured_vcs_client.go 0% <0%> (ø) ⬆️
server/events/vcs/gitlab_client.go 19.81% <0%> (-1.41%) ⬇️
server/events/vcs/bitbucketserver/client.go 32% <0%> (-3.83%) ⬇️
server/events/yaml/raw/project.go 100% <100%> (ø) ⬆️
server/server.go 66.27% <100%> (+0.26%) ⬆️
server/events/vcs/github_client.go 67.94% <75%> (+5.09%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27eb577...b6d8213. Read the comment docs.

@lkysow lkysow merged commit 858dbe4 into master Dec 12, 2018
@lkysow lkysow deleted the mergeable-pr branch December 12, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant