fix: Enforce policy checks for overridden apply reqs #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfm
changed the title
This new version only includes the 'policies_passed' req back if policy checks are enabled for the project.
|
FYI I just tested this change in our environment, and it's now working as I would expect, that is, even when setting
|
danielfm
changed the title
|
@jamengual The spelling errors were corrected! 😄 |
jamengual
added
waiting-on-review
GenPage
approved these changes
Dec 12, 2023
GenPage
added
bug
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Enforce policy checks for overriden apply reqs * Another take on the fix This new version only includes the 'policies_passed' req back if policy checks are enabled for the project. * Fix test * Fix comment * Fix spelling --------- Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
* Enforce policy checks for overriden apply reqs * Another take on the fix This new version only includes the 'policies_passed' req back if policy checks are enabled for the project. * Fix test * Fix comment * Fix spelling --------- Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Keeps the
policies_passedapply requirement for projects that override the apply requirements via the repo levelatlantis.yamlfile.why
Without this change, projects that override the apply requirements via the repo level
atlantis.yamlfile do not include thepolicies_passedrequirement even when policy checks is enabled, which ultimately allows bypassing policy checking approval when a policy fails and at least 1 approval is required.I believe this is a security issue, as many Atlantis installations use conftest policies to enforce security best practices or to protect against misuse, i.e. block the removal of critical resources, and it's expected that these policies are enforced when policy checks is enabled.
tests
Added two new unit tests, to ensure that:
apply_requirementsalways includepolicies_passedif policy checks are enabledapply_requirementsare kept as-is if policy checks are disabledreferences
policies_passedrequirement removed when overriden in repo level configuration #3908