feat: Add missing test flags #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing because main itself is broken, looking into this now |
lukemassa
force-pushed
the
add_missing_test_flags
branch
from
ca668f7
to
84c0f03
Compare
jamengual
approved these changes
Dec 18, 2023
|
/cherry-pick release-0.27 |
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add a number of missing flags to testFlags.
why
These are supposed to be added when users add new flags, looks like they were just omitted.
I opened #4063 to address the larger issue of preventing this drift in the future, this just does a backfill.
All the defaults are taken from server.go.
tests
Unit tests passing should be sufficient, this is just for completeness.
references
Partially addresses: #4063