revert: regression: remote ops detection TF v1.1 #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypres
requested review from
GenPage,
lukemassa and
nitrocode
and removed request for
a team
cypres
referenced
this pull request
Jan 23, 2024
* chore(atlantis): fix linter errors * fix superfluous-else * revert gitlab check * ignore stub funcs on azuredevops_client * remove fetch-depth * remove fail_on_error * fix plan_step_runner_test.go * more lint fixes --------- Co-authored-by: Dylan Page <dylan.page@autodesk.com>
|
@cypres there is also a test that validates that output. Please search for that text to add it there too. And would be nice to leave a comment since it’s that important! |
Reverts linter change from runatlantis#3690 which breaks TF v1.1 detection
Thank you, I should have done that. Better now? |
GMartinez-Sisti
approved these changes
Jan 23, 2024
GenPage
approved these changes
Jan 23, 2024
|
/cherry-pick release-0.27 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 8, 2024
Reverts linter change from #3690 which breaks TF v1.1 detection
GenPage
pushed a commit
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts linter change from 56e38b4 (#3690) which breaks TF v1.1 detection
what
Reverts a simple commit for a single file to fix remote operations for TF v1.1+
why
Without this revert you can't use Atlantis with Terraform Cloud v1.1+, see #2793 for why this was introduced in the first place.
tests
To prepare this I did
git checkout 2e6758e -- server/core/runtime/plan_step_runner.goand picked the corresponding change from
server/core/runtime/plan_step_runner_test.goreferences