Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Tunnelmole as an open source alternative to ngrok #4361

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

robbie-cahill
Copy link

This PR adds Tunnelmole as a tunneling option.

Tunnelmole is a FOSS tunnelling solution with a growing community. It works out of the box and can be optionally self hosted with the Tunnelmole Service. Both the client and service are open source.

Example:

➜  ~ tmole 8000
http://bvdo5f-ip-49-183-170-144.tunnelmole.net is forwarding to localhost:8000
https://bvdo5f-ip-49-183-170-144.tunnelmole.net is forwarding to localhost:8000

@robbie-cahill robbie-cahill requested review from a team as code owners March 15, 2024 10:16
@robbie-cahill robbie-cahill requested review from GenPage, nitrocode and X-Guardian and removed request for a team March 15, 2024 10:16
@github-actions github-actions bot added the docs Documentation label Mar 15, 2024
runatlantis.io/guide/testing-locally.md Outdated Show resolved Hide resolved
Comment on lines 16 to 18
## Tunnelmole Setup
First install Tunnelmole. You can check out the [Installation Guide](https://tunnelmole.com/docs/#installation). For most use cases, this will be done with a single command copy/pasted into your terminal. Running Tunnelmole can be as simple as `tmole <port>`(replace `<port>` with your listening port). In the output, you'll find an HTTP and HTTPS URL. It's recommended to use the HTTPS URL for improved privacy and security.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest removing this paragraph, as there is no ngrok setup detail in this document, so having this extra Tunnelmole detail here is confusing here if you intend to use ngrok. You already have links to the tunnelmole docs and the additional setup detail in the testling-locally.md file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I've removed it.

@@ -40,30 +58,28 @@ URL="https://{YOUR_HOSTNAME}.ngrok.io"
```

## Create a Webhook Secret
GitHub and GitLab use webhook secrets so clients can verify that the webhooks came
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this section are out of scope of your PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the diff GitHub is showing here is a bit misleading. This section has moved to line 60, so the line "GitHub and GitLab use webhook secrets so clients can verify that the webhooks came" is still there on line 61.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have changed the line breaks and modified the lines of this section which has caused the Git diffs. These changes aren't really anything to do with the Tunnelmole detail you have added, so to make PRs easier to review, it is preferable if you don't make these changes in this PR.

<details>
<summary>Expand</summary>
<summary>GitHub or GitHub Enterprise Webhook</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are including changes outside the scope of your PR, please detail/justify these in the PR description.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now reverted

runatlantis.io/guide/testing-locally.md Outdated Show resolved Hide resolved
@X-Guardian X-Guardian changed the title Add Tunnelmole as an open source alternative to ngrok docs: Add Tunnelmole as an open source alternative to ngrok Mar 15, 2024
@jamengual jamengual added needs discussion Large change that needs review from community/maintainers and removed needs discussion Large change that needs review from community/maintainers labels Mar 15, 2024
robbie-cahill and others added 4 commits March 19, 2024 20:15
Co-authored-by: Simon Heather <32168619+X-Guardian@users.noreply.github.com>
Co-authored-by: Simon Heather <32168619+X-Guardian@users.noreply.github.com>
@@ -40,30 +58,28 @@ URL="https://{YOUR_HOSTNAME}.ngrok.io"
```

## Create a Webhook Secret
GitHub and GitLab use webhook secrets so clients can verify that the webhooks came
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have changed the line breaks and modified the lines of this section which has caused the Git diffs. These changes aren't really anything to do with the Tunnelmole detail you have added, so to make PRs easier to review, it is preferable if you don't make these changes in this PR.

@X-Guardian
Copy link
Contributor

Can you resolve the conflicts @robbie-cahill?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants