New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Tunnelmole as an open source alternative to ngrok #4361
base: main
Are you sure you want to change the base?
Conversation
runatlantis.io/guide/test-drive.md
Outdated
## Tunnelmole Setup | ||
First install Tunnelmole. You can check out the [Installation Guide](https://tunnelmole.com/docs/#installation). For most use cases, this will be done with a single command copy/pasted into your terminal. Running Tunnelmole can be as simple as `tmole <port>`(replace `<port>` with your listening port). In the output, you'll find an HTTP and HTTPS URL. It's recommended to use the HTTPS URL for improved privacy and security. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest removing this paragraph, as there is no ngrok setup detail in this document, so having this extra Tunnelmole detail here is confusing here if you intend to use ngrok. You already have links to the tunnelmole docs and the additional setup detail in the testling-locally.md
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I've removed it.
@@ -40,30 +58,28 @@ URL="https://{YOUR_HOSTNAME}.ngrok.io" | |||
``` | |||
|
|||
## Create a Webhook Secret | |||
GitHub and GitLab use webhook secrets so clients can verify that the webhooks came |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this section are out of scope of your PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the diff GitHub is showing here is a bit misleading. This section has moved to line 60, so the line "GitHub and GitLab use webhook secrets so clients can verify that the webhooks came" is still there on line 61.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have changed the line breaks and modified the lines of this section which has caused the Git diffs. These changes aren't really anything to do with the Tunnelmole detail you have added, so to make PRs easier to review, it is preferable if you don't make these changes in this PR.
<details> | ||
<summary>Expand</summary> | ||
<summary>GitHub or GitHub Enterprise Webhook</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are including changes outside the scope of your PR, please detail/justify these in the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is now reverted
Co-authored-by: Simon Heather <32168619+X-Guardian@users.noreply.github.com>
Co-authored-by: Simon Heather <32168619+X-Guardian@users.noreply.github.com>
@@ -40,30 +58,28 @@ URL="https://{YOUR_HOSTNAME}.ngrok.io" | |||
``` | |||
|
|||
## Create a Webhook Secret | |||
GitHub and GitLab use webhook secrets so clients can verify that the webhooks came |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have changed the line breaks and modified the lines of this section which has caused the Git diffs. These changes aren't really anything to do with the Tunnelmole detail you have added, so to make PRs easier to review, it is preferable if you don't make these changes in this PR.
Can you resolve the conflicts @robbie-cahill? |
This PR adds Tunnelmole as a tunneling option.
Tunnelmole is a FOSS tunnelling solution with a growing community. It works out of the box and can be optionally self hosted with the Tunnelmole Service. Both the client and service are open source.
Example: