fix(tests): Sort results in command builder before comparing #4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
jamengual,
nitrocode and
X-Guardian
and removed request for
a team
GenPage
previously approved these changes
Mar 26, 2024
jamengual
approved these changes
Mar 26, 2024
|
Thanks for this. Golang is a very new language for me and the amount of time I spent on these tests alone I'd rather not say 😅 |
nitrocode
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Sort results of
builder.BuildAutoplanCommandsbefore comparing to expected values in tests.why
The tests are currently flakey, per: #4363 (comment).
A potential follow up might be to have
BuildAutoplanCommandsreturn a sorted list, but that might have more implications so I'll leave that for now.tests
make testnow consistently passes.references