fix: adapt terraform download due to new folder zip structure #4478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkferreira
requested review from
GenPage,
lukemassa and
nitrocode
and removed request for
a team
rkferreira
changed the title
|
My opinion here is this isn't a big enough step forward from our current workaround (#4474) to warrant another change just yet. We should consider #4472 (comment) from Core TF to see if we can reach a long term stable solution. If that turns out to be impossible, or take too long, such that users need some feature of 2.8.2 or beyond, I'd suggest we'd revisit this as an alternative. |
1 task
jamengual
added
the
wont-do
rkferreira
force-pushed
the
workaround_latet_tf_folder
branch
from
9df775d
to
24f338e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Short-term fix for #4471. With this change Atlantis will download terraform version 1.8.2 or any new one.
why
Terraform packaging was changed in release 1.8.2 (see https://github.com/hashicorp/terraform/releases/tag/v1.8.2) and Atlantis throws an error for every default and custom workflow when trying to download it. Proper, long-term fix is described here - #4472 (comment).
tests
No test cases added.
It was tested running atlantis testdrive and reproducing the scenario.
references
See #4471 and #4472 for more info about issue and various workarounds.