Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dumb-init and gosu versions #730

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@chenrui333
Copy link
Contributor

commented Aug 11, 2019

Upgrade dumb-init and gosu versions the latest

@codecov

This comment has been minimized.

Copy link

commented Aug 11, 2019

Codecov Report

Merging #730 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #730   +/-   ##
=======================================
  Coverage   72.25%   72.25%           
=======================================
  Files          62       62           
  Lines        4728     4728           
=======================================
  Hits         3416     3416           
  Misses       1057     1057           
  Partials      255      255

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebebe5...38a9f71. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Aug 11, 2019

Codecov Report

Merging #730 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #730   +/-   ##
=======================================
  Coverage   72.25%   72.25%           
=======================================
  Files          62       62           
  Lines        4728     4728           
=======================================
  Hits         3416     3416           
  Misses       1057     1057           
  Partials      255      255

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebebe5...38a9f71. Read the comment docs.

@lkysow

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Hi Chenrui,
Can you say what changed between these releases and describe why we should update please. I don't think it makes sense to bump versions simply because there is a new release. I would want there to be bugfixes or security updates that make the change worth the risk.

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Yeah, I do see the value of bumping the versions of dumb-init, here are the release notes of it.

Release notes:

v1.2.2 released on Aug 1, 2018

Fix a race condition which can cause the child to receive SIGHUP and SIGCONT very shortly after start.

In general this was very rare, but some environments (especially some container and virtualization environments) appear to encounter it at a much higher rate, possibly due to scheduler quirks.

v1.2.1 released on Dec 1, 2017

Fix verbose debug logging for ignored signals.

Before this patch, they were reported in the verbose log as "forwarded
signal 0 to children" instead of "not forwarding signal to children".

Since signal 0 is a noop, there is no actual behavior change here.

Fix Python package installation on platforms without -static support (e.g. Mac OS X)

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

For Gosu one it is nice to have upgrade.

releases notes

1.11 released on Oct 15, 2018

  • built on Go 1.11.1, runc 1.0.0-rc5, Alpine 3.8
  • added explicit --version and --help flag
@chenrui333

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

in general, it might be a good strategy to keep these releases up to date.

As I read thru these release notes, I did not see any issues myself (and I already used the patches myself).

@lkysow

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

👍 thanks for the summary

@lkysow lkysow merged commit 23e3099 into runatlantis:master Aug 13, 2019

4 checks passed

ci/circleci: e2e Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: website_link_check Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.