Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to enable confidential vm #130

Merged
merged 1 commit into from Dec 8, 2023
Merged

feat: add option to enable confidential vm #130

merged 1 commit into from Dec 8, 2023

Conversation

d-costa
Copy link
Collaborator

@d-costa d-costa commented Nov 27, 2023

what

  • Give users the option to enable Confidential VM feature

why

references

@bschaatsbergen
Copy link
Contributor

Hey @d-costa, thanks a lot for raising this pull request - I'll review it as soon as possible!

@bschaatsbergen
Copy link
Contributor

Please rebase on main @d-costa

@bschaatsbergen bschaatsbergen added the major Breaking changes (or first stable release) label Dec 4, 2023
@d-costa d-costa force-pushed the confidential-vms branch 2 times, most recently from 71b111e to eac829b Compare December 5, 2023 16:35
bschaatsbergen
bschaatsbergen previously approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bschaatsbergen
Copy link
Contributor

Could you please rebase again @d-costa - would love to merge this today.

bschaatsbergen
bschaatsbergen approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bschaatsbergen bschaatsbergen merged commit a167d33 into runatlantis:main Dec 8, 2023
1 check passed
@d-costa d-costa deleted the confidential-vms branch January 5, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschaatsbergen bschaatsbergen bschaatsbergen approved these changes

Assignees
No one assigned
Labels
major Breaking changes (or first stable release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d-costa @bschaatsbergen