Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: shared vpc support #137

Merged
merged 1 commit into from Jan 5, 2024
Merged

feat: shared vpc support #137

merged 1 commit into from Jan 5, 2024

Conversation

d-costa
Copy link
Collaborator

@d-costa d-costa commented Dec 7, 2023

what

  • Give users the option to deploy in shared vpc architectures
  • When enabled, the firewall rule and default route are not created, and the host project id is used in the instance template's network configuration.
  • Create a new example using this feature under examples/shared_vpc

why

  • These changes allow this module to be deployed in projects that use Shared VPC

references

Let me know how you feel about these changes and the accompanied example 馃槃

@bschaatsbergen
Copy link
Contributor

bschaatsbergen commented Dec 8, 2023 •
edited

Please rebase this one too @d-costa - awesome that you picked this up!

bschaatsbergen
bschaatsbergen reviewed Dec 8, 2023
View reviewed changes
main.tf Show resolved Hide resolved
@bschaatsbergen
Copy link
Contributor

Solid PR! 1 minor fix to be done on the "how to deploy" reference @d-costa

bschaatsbergen
bschaatsbergen approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃殌

@bschaatsbergen bschaatsbergen merged commit 83da2b3 into runatlantis:main Jan 5, 2024
1 check passed
@bschaatsbergen bschaatsbergen mentioned this pull request Jan 5, 2024
Open
@d-costa d-costa deleted the shared_vpc branch January 5, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschaatsbergen bschaatsbergen bschaatsbergen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Shared VPC deployments
2 participants
@d-costa @bschaatsbergen