Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable secure boot #93

Merged
merged 1 commit into from Mar 16, 2023
Merged

Enable secure boot #93

merged 1 commit into from Mar 16, 2023

Conversation

kpocius
Copy link
Contributor

@kpocius kpocius commented Jan 27, 2023 •
edited

what

  • Set enable_secure_boot to true (hardcoded)

why

  • Secure boot is an additional security feature to harden the resulting VM -- since VTPM & integrity monitoring were already turned on by default, it only makes sense to have it on too
  • Setting this value will force the instance to be recreated, so this is a breaking change

@kpocius kpocius mentioned this pull request Jan 27, 2023
Closed
@bschaatsbergen bschaatsbergen added the major Breaking changes (or first stable release) label Feb 9, 2023
@bschaatsbergen
Copy link
Contributor

Hi @kpocius , I plan on creating a branch for breaking changes soon and will include this change in there.

@bschaatsbergen bschaatsbergen changed the base branch from main to breaking-changes March 16, 2023 19:55
bschaatsbergen
bschaatsbergen approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bschaatsbergen
Copy link
Contributor

Merging this to the breaking-changes branch.

@bschaatsbergen bschaatsbergen merged commit 28eb545 into runatlantis:breaking-changes Mar 16, 2023
@bschaatsbergen
Copy link
Contributor

Thanks for your contribution @kpocius 👏🏼

@kpocius kpocius mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschaatsbergen bschaatsbergen bschaatsbergen approved these changes

Assignees
No one assigned
Labels
major Breaking changes (or first stable release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kpocius @bschaatsbergen