fix(identities): Split out "username" profile and protect it #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New thought: Don't highlight the identity on the main page listing, instead, where the "delete" box would appear (which it doesnt cos you cant delete it), add an explanation? |
antoniskalou
requested changes
Oct 17, 2023
castaway
force-pushed
the
castaway/1463_username_identity
branch
from
419f00c
to
24b4b82
Compare
antoniskalou
approved these changes
Mar 29, 2024
antoniskalou
approved these changes
Apr 1, 2024
castaway
force-pushed
the
castaway/1463_username_identity
branch
from
1cc7cb4
to
549a795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1463
@gtandersen I'm passing you the baton for ideas on how to actually make the "username" identity stand out, currently I just have it with a red highlight the same as the "Email not validated".. however I think it should probably be a solid border, or a different shade or something?
TODO: Integration + unit tests for profiles