feat(app): Use a new API to pre-cache messages in bulk #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadzik
commented
Mar 16, 2021
src/app/rmmapi/rbwebmail.ts
Outdated
| ); | ||
| } | ||
|
|
||
| //return Promise.allSettled(messagePromises); |
There was a problem hiding this comment.
Not sure yet if we'd actually prefer allSettled() here or not, but it doesn't compile under our current setup so far anyway ;) If we go for it, we might need a polyfill to make it work on ancient browsers too.
tadzik
force-pushed
the
tadzik/bulk-message-downloads
branch
from
735ebe1
to
6a39311
Compare
Introduces a "contact support" component, since it's a UI pattern we repeat a lot.
tadzik
force-pushed
the
tadzik/bulk-message-downloads
branch
from
6a39311
to
797f41f
Compare
castaway
reviewed
Sep 21, 2021
| @@ -144,30 +144,26 @@ export class MockServer { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| const bulkemailendpiont = requesturl.match(/\/rest\/v1\/email\/download\/([0-9,]+)/); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be similarly adopted in the SearchService.