Get all ec2 response pages #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate async and sync queries fixes rundeck-plugins#93
|
I have added a configuration option to set the max results per AWS request. Successfully smoked test this locally with the default and a page size of 5 and all nodes showing up. |
|
Rundeck manages caching and loading the nodes in separate threads within an executor already. This plugin has a toggle for "asynch" loading, which is disabled by default now due to this new-ish behavior in Rundeck. So i'd suggest that if the asynch==false, it should avoid using another thread |
|
@gschueler I believe the latest changes should address your feedback. |
|
fixes this? #76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pages through the AWS request to ensure all instances are fetched. The query workflow has been collapsed into a single method to simplify the paging, and is run in background thread via the executor service.