Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding image name to instance attributes #99

Merged
merged 3 commits into from
May 30, 2019
Merged

adding image name to instance attributes #99

merged 3 commits into from
May 30, 2019

Conversation

ltamaster
Copy link
Contributor

@ltamaster ltamaster commented May 29, 2019 •
edited

  • adding image name to the instance attributes

@ltamaster
- fixing onlyRunning flag
24a2b84 
- adding image name to the instance attributes
@ltamaster ltamaster requested a review from gschueler May 29, 2019 21:18
@gschueler
Copy link
Member

i think you should separate these two changes into two prs (fixing the onlyRunning tag, vs imageName).

for the imageName: perhaps there's no need to make the describeImages request if the mapping doesn't include the imageName, correct?

@ltamaster ltamaster changed the title fixing only running flag, adding image name adding image name to instance attributes May 30, 2019
@ltamaster
Copy link
Contributor Author

@gschueler I added what you mentioned

@gschueler gschueler merged commit a26f494 into master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschueler gschueler Awaiting requested review from gschueler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ltamaster @gschueler