Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official docker image propagates sensitive variables to local jobs #4904

Closed
jairov4 opened this issue Jun 4, 2019 · 2 comments · Fixed by #4912
Closed

Official docker image propagates sensitive variables to local jobs #4904

jairov4 opened this issue Jun 4, 2019 · 2 comments · Fixed by #4912
Assignees
Labels
Milestone

Comments

@jairov4
Copy link
Contributor

jairov4 commented Jun 4, 2019

Is your feature request related to a problem? Please describe.
When a rundeck container using environment variable configuration for database or LDAP, those secrets can be seen by jobs executing locally to the container. Sensitive configuration information should be not available for child jobs by default.

Describe the solution you'd like
Unset sensitive variables after configuration consolidation by remco and before rundeck process start.

Describe alternatives you've considered
Unset sensitive variables after configuration consolidation by remco and before rundeck process start.

Additional context
Sensitive configuration information should be not available for child jobs by default.

@ProTip
Copy link
Contributor

ProTip commented Jun 5, 2019

Hi @jairov4 ,

Apologies for not seeing your PR before I started mine! Would #4912 suite your needs? We a number of different configuration layers in use, stock plugins with secrets, and our enterprise image builds on top of this as well. As such unsetting all RUNDECK_ prefixed envars by default instead of maintaining an explicit list of sensitive envars may be a better approach. An example would be AWS credentials for the S3 log storage plugin.

Take a look and let me know what you think!

Cheers,
-Greg

@jairov4
Copy link
Contributor Author

jairov4 commented Jun 5, 2019

@ProTip Looks like yours is more general solution :)
I like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants