Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Disable AutoComplete on password field of Rundeck login page #5205

Closed
markp80 opened this issue Sep 4, 2019 · 1 comment · Fixed by #5260
Closed

Ability to Disable AutoComplete on password field of Rundeck login page #5205

markp80 opened this issue Sep 4, 2019 · 1 comment · Fixed by #5260

Comments

@markp80
Copy link

markp80 commented Sep 4, 2019

Our server running Rundeck 3.0.24 is scanned by Qualys Vulnerability scanning and has detected the following vulnerability. Plesse could we have the ability to disable AutoComplete at the application level.

AutoComplete Attribute Not Disabled for Password in Form Based Authentication

THREAT: The Web server allows form based authentication without disabling the AutoComplete feature for the password field. Autocomplete should be turned off for any input that takes sensitive information such as credit card number, CVV2/CVC code, U.S. social security number, etc.

IMPACT: If the browser is used in a shared computing environment where more than one person may use the browser, then "autocomplete" values may be retrieved or submitted by an unauthorized user.

SOLUTION: Contact the vendor to have the AutoComplete attribute disabled for the password field in all forms. The AutoComplete attribute should also be disabled for the user ID field. Developers can add the following attribute to the form or input element: autocomplete="off" This attribute prevents the browser from prompting the user to save the populated form values for later reuse. Most browsers no longer honor autocomplete="off" for password input fields. These browsers include Chrome, Firefox, Microsoft Edge, IE, Opera However, there is still an ability to turn off autocomplete through the browser and that is recommended for a shared computing environment. Since the ability to turn autocomplete off for password inputs fields is controlled by the user it is highly recommended for application to enforce strong password rules.

Mark

@runephilosof
Copy link
Contributor

I would say Qualys is wrong in this recommendation. Which is an opinion shared by the browser vendors, since they don't honor the autocomplete="off".
Unique passwords and Password Managers is the best practice.
You shouldn't turn off autocompletion just because some users might use a shared os account (and have the browser save the password).
A shared account (such as a library computer) should instead have that browser feature turned off.

It would probably be a good idea to contact Qualys for arguments.

runephilosof added a commit to runephilosof/rundeck that referenced this issue Sep 16, 2019
To satisfy Qualys Vulnerability scanning.
Even though it isn't best practice, because best practice is to use password managers to autocomplete the login fields.
However, it won't be honored by the browsers (for the above reason https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#The_autocomplete_attribute_and_login_fields), so users won't get affected.
So this change is only good to silence a vulnerability scanner, it doesn't actually close a vulnerability.

Closes rundeck#5205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants