Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job import/export removes failOnDisable: true #6335

Closed
ajxb opened this issue Dec 10, 2018 · 4 comments · Fixed by #6417
Closed

Job import/export removes failOnDisable: true #6335

ajxb opened this issue Dec 10, 2018 · 4 comments · Fixed by #6417
Milestone
3.3.4

Comments

@ajxb
Copy link
Contributor

ajxb commented Dec 10, 2018

Hi,

I believe I have encountered the same problem as rundeck/rundeck-cli#201 with the failOnDisable option, when I upload a number of jobs that were exported from another system to a new target system, the failOnDisable flag is reset when it was set to true in the yaml file and on the source machine.

I've spotted that if I move the failOnDisable: true setting to be an element of the jobref: map and import the option is correctly retained.

I'm using the following:

  • RunDeck 2.11.8
  • RunDeck 1.1.0.SNAPSHOT-1
@stale
Copy link

stale bot commented Feb 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ajxb
Copy link
Contributor Author

ajxb commented Feb 11, 2019

This issue is still present

@stale
Copy link

stale bot commented Apr 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this as completed Apr 19, 2019
@gschueler gschueler transferred this issue from rundeck/rundeck-cli Aug 3, 2020
@gschueler gschueler reopened this Aug 3, 2020
@gschueler
Copy link
Member

similar to #3429 the issue exists for the failOnDisable flag for job reference

@gschueler gschueler changed the title rd jobs load removes failOnDisable: true Job import/export removes failOnDisable: true Aug 3, 2020
@gschueler gschueler added this to the 3.3.3 milestone Aug 14, 2020
gschueler added a commit that referenced this issue Aug 27, 2020
@gschueler
Fix #6335 failOnDisable flag in jobref definition not serialized/load…
73d4ddf 
…ed correctly
@gschueler gschueler mentioned this issue Aug 27, 2020
Merged
@gschueler gschueler modified the milestones: 3.3.3, 3.3.4 Aug 29, 2020
gschueler added a commit that referenced this issue Sep 14, 2020
@gschueler
Merge pull request #6417 from rundeck/issue/6335
90e4acb 
Fix #6335 failOnDisable flag in jobref definition not serialized/loaded correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.4
Development

Successfully merging a pull request may close this issue.

Fix #6335 failOnDisable flag in jobref definition not serialized/loaded correctly rundeck/rundeck
2 participants
@gschueler @ajxb