Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better child job support #3040

Merged

Conversation

jtobard
Copy link
Contributor

@jtobard jtobard commented Jan 5, 2018

Add these enhancements:

  • Trigger notifications
  • Update statistics
  • Timeout
  • Skip job when it has disabled execution

Trigger notifications

Referenced jobs now trigger their notifications (onstart, onavgduration, onsuccess, onfailure) as expected. #1841 #1574

The notifications are dispatched every time the referenced job runs.
The default html template also includes a header reference to the referenced job that triggers the notification:
image

changes to:

image

Update statistics

The execution of referenced jobs now updates his statistics (Average Duration and Success Rate).
And (if the job has been called by another job at least once) on the recent, failed and by me tabs, the parent executions are displayed, with the added text (Referenced), as links to the parent execution that runs the current job.

image

Timeout

Respect timeout of the job when is called using job reference.
See #2911

Skip job when it has disabled execution

The task is marked as incomplete and ignore the job ref.
A new property is added to the Job Reference plugin, Fail on disabled execution? If checked, the job reference will be considered as a failure if it has execution disabled, otherwise it will be ignored.

image

jtobard and others added 27 commits December 12, 2017 13:43
@jtobard jtobard added this to the 2.11.x milestone Jan 5, 2018
@gschueler gschueler changed the base branch from master to prerelease-2.11.0 January 5, 2018 18:49
@gschueler gschueler merged commit 24126be into rundeck:prerelease-2.11.0 Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants