Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5030 - This changes make validations if the options from URL is a json object or a simple array list of options… #5031

Merged
merged 3 commits into from Jul 8, 2019

Conversation

@carlosrfranco
Copy link
Contributor

commented Jul 3, 2019

Is this a bugfix, or an enhancement? Please describe.
The remote URL options validation fail if the json uses a json object format

Describe the solution you've implemented
The validation was considering just a simple array list values, so, when the json uses a object format, the validation failed. I changed this validation to consider a json object format when it is used

Fixes #5030 - This changes make validations if the options from URL i…
…s a json object or a simple array list of options

@carlosrfranco carlosrfranco requested a review from jtobard Jul 3, 2019

@jtobard
Copy link
Contributor

left a comment

I tested on my local env and this works.
Can you add a unit test for this on ExecutionServiceSpec.groovy?

@jtobard jtobard added this to the 3.1.0-RC2 milestone Jul 4, 2019

@jtobard

jtobard approved these changes Jul 4, 2019

Copy link
Contributor

left a comment

👍

@jtobard jtobard merged commit 03dc844 into rundeck:master Jul 8, 2019

20 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
@puremourning

This comment has been minimized.

Copy link

commented on aae1eea Jul 8, 2019

No regression test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.