Fix #5083 - Fixing the regex expression to consider "." character when perform auto completions #5300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter when perform auto completions
jessemarple
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
If some characters are typed after @option. and then an item is selected from the autocomplete dropdown menu, @option. is inserted again at the beginning and an extra "@" is added at the end
Describe the solution you've implemented
This solution changes the regular expression to consider "." as a valid character on prefix input text when perform auto completions.
Describe alternatives you've considered
Initially, I was trying to custom the "getCompletions" function from auto completion tool library.