Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5083 - Fixing the regex expression to consider "." character when perform auto completions #5300

Merged
merged 1 commit into from Sep 26, 2019

Conversation

@carlosrfranco
Copy link
Contributor

commented Sep 26, 2019

Is this a bugfix, or an enhancement? Please describe.
If some characters are typed after @option. and then an item is selected from the autocomplete dropdown menu, @option. is inserted again at the beginning and an extra "@" is added at the end

Describe the solution you've implemented
This solution changes the regular expression to consider "." as a valid character on prefix input text when perform auto completions.

Describe alternatives you've considered
Initially, I was trying to custom the "getCompletions" function from auto completion tool library.

…n perform auto completions
@carlosrfranco carlosrfranco requested a review from jessemarple Sep 26, 2019
@carlosrfranco carlosrfranco self-assigned this Sep 26, 2019
Copy link
Contributor

left a comment

Reviewed and Approved

@carlosrfranco carlosrfranco added this to the 3.1.2 milestone Sep 26, 2019
@jessemarple jessemarple added the v3.1.2 label Sep 26, 2019
@jessemarple jessemarple removed this from the 3.1.2 milestone Sep 26, 2019
@ProTip ProTip added this to the 3.1.2 milestone Sep 26, 2019
@ProTip ProTip merged commit 5c50926 into rundeck:master Sep 26, 2019
20 checks passed
20 checks passed
Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.