Changing the mechanism that loads the plugins into memory to consider the type of the plugin in addition to its name #5737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the type of the plugin in addition to its name
gschueler
requested changes
Jan 28, 2020
There was a problem hiding this comment.
Should also change the resources.groovy where several plugin beans are defined in the registry map directly, see:
https://github.com/rundeck/rundeck/blob/master/rundeckapp/grails-app/conf/spring/resources.groovy#L392-L400
e.g. change pluginRegistry['db']='dbStoragePluginFactory' to pluginRegistry['Storage:db']='dbStoragePluginFactory'
core/src/main/java/com/dtolabs/rundeck/core/plugins/PluginRegistry.java
Outdated
Show resolved
Hide resolved
gschueler
approved these changes
Jan 28, 2020
jtobard
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes is a bugfix for https://github.com/rundeckpro/rundeckpro/issues/849
Is this a bugfix, or an enhancement? Please describe.
This changes fixes a wrong behaviour that did not allow plugins of different types to have the same provider name
Describe the solution you've implemented
Was changed the way that the plugins is registered into registryMap and loaded in memory. So now it is using the type in addition to name provider on the registryMap