New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Execution viewer release work #6157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content overflow
Scope ant styles Preserve whitespace in vue template compile
Remove extraneous logging Restore line linking
Disable legacy viewer by default; not a great way to choose on commands and node flow
"Settings/loading bar always visible". this doesnt seem to work for me. when scolling down, the controls disappear (Safari 13) |
gschueler
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to have the sticky settings work in safari, but it does work in chrome/firefox
sjrd218
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewer Changes
This PR updates the new execution viewer and swaps it in as the default for the execution show page. Legacy viewer is available and can be toggled with a feature flag. I propose we leave it enabled by default through most of the release testing..
UI Trellis / Misc
PR also includes a lot of work done along the way on UI Trellis; specifically around: