Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Execution viewer release work #6157

Merged
merged 36 commits into from Jun 23, 2020
Merged

New Execution viewer release work #6157

merged 36 commits into from Jun 23, 2020

Conversation

ProTip
Copy link
Contributor

@ProTip ProTip commented Jun 19, 2020

Viewer Changes

This PR updates the new execution viewer and swaps it in as the default for the execution show page. Legacy viewer is available and can be toggled with a feature flag. I propose we leave it enabled by default through most of the release testing..

  • Default viewer for execution show
  • ANSI color toggle
  • Gutter text overflow hidden with ellipsis instead of wrap
  • Toggle for content line wrap
  • Node badge display toggle
  • Settings form inputs using bootstrap styles
  • Settings/loading bar always visible
  • Fix for execution output without stepctx(failed jobs, debug, etc)
  • All settings changes take effect immediately
  • Hooked into AdHoc Command page
  • Hooked into "node view" on show page

UI Trellis / Misc

PR also includes a lot of work done along the way on UI Trellis; specifically around:

  • Storybook setup, configuration
    • Rundeck sytles imported and compiled
    • Source maps
    • Utilities for recording and playing back API calls
  • Jest test setup(kinda bare ATM)

story

@ProTip ProTip requested a review from gschueler June 19, 2020 20:19
@mergify mergify bot added the 3.3.x label Jun 19, 2020
@ProTip ProTip added this to the 3.3.0-M3 milestone Jun 19, 2020
@ProTip ProTip changed the base branch from master to main June 20, 2020 03:37
Disable legacy viewer by default; not a great way to choose on commands and node flow
@ProTip ProTip requested a review from sjrd218 June 22, 2020 20:21
@gschueler
Copy link
Member

gschueler commented Jun 22, 2020

"Settings/loading bar always visible". this doesnt seem to work for me. when scolling down, the controls disappear (Safari 13)

Copy link
Member

@gschueler gschueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to have the sticky settings work in safari, but it does work in chrome/firefox

@gschueler gschueler merged commit e7ba195 into main Jun 23, 2020
@gschueler gschueler deleted the nu-execution-viewer branch June 23, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants