Rundeck initialization refactoring #6414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup initialization code, and refactor it to work the same in container and non-container installations. Add an unsecured health check endpoint. Add cleanup code for metrics and log storage service upon server restart or shutdown. Add plumbing for hot restart capability.
sjrd218
force-pushed
the
enh/hotrestart
branch
from
2e4c6c3
to
7874985
Compare
|
@gschueler @ProTip I have update this PR as discussed. For some reason Travis won't let me restart the failed test run, otherwise it'd be passing. |
gschueler
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor server uuid assignment and loading.
Cleanup initialization code, and refactor it to work the same in container and non-container installations.
Add an unsecured health check endpoint.
Add cleanup code for metrics and log storage service upon server restart or shutdown.
Add plumbing for hot restart capability.
The initialization method in the FrameworkService has been removed and the serverUuid now comes from a system property that is set in the prebootstrap phase of the Rundeck startup. This helps avoid some of the issues we've had in the past with the system triggering the initialization at the wrong time.
The server uuid now comes from a file calledserverIdlocated in the server config directory. The id from framework.properties is migrated into the file if it exists. If the environment variableRUNDECK_SERVER_UUIDor therundeck.server.uuidsystem property is set by the user, that value will be used for the server id and will be installed in the serverId file.