Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUN-538: Ace editor no contrast in dark mode #7612

Merged
merged 5 commits into from Mar 30, 2022
Merged

RUN-538: Ace editor no contrast in dark mode #7612

merged 5 commits into from Mar 30, 2022

Conversation

L2JE
Copy link
Contributor

@L2JE L2JE commented Mar 29, 2022 •
edited

Fix: https://github.com/rundeckpro/rundeckpro/issues/2186

Ace editor theme was fixed to ace/theme/chrome since: 04f0335

It fixes at least the following ace editor views:

  • Ruleset WF strategy
  • Inline script
  • Ansible Inline Playbooks

@mergify mergify bot added the 4.x label Mar 29, 2022
@mishingo mishingo added this to the 4.1.0 milestone Mar 29, 2022
@mishingo mishingo self-requested a review March 29, 2022 21:21
@L2JE L2JE merged commit 5fc504a into main Mar 30, 2022
@L2JE L2JE deleted the fix/ace-editor-dark-mode branch March 30, 2022 15:14
@L2JE L2JE restored the fix/ace-editor-dark-mode branch March 30, 2022 15:24
@L2JE L2JE mentioned this pull request Mar 30, 2022
Merged
@fdevans fdevans mentioned this pull request Mar 31, 2022
Closed
@L2JE L2JE mentioned this pull request Apr 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishingo mishingo mishingo approved these changes

Assignees
No one assigned
Labels
4.x
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@L2JE @mishingo