RUN-1261: Dynamic default values for properties plugins #8356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschueler
previously requested changes
May 30, 2023
rundeckapp/grails-app/controllers/rundeck/controllers/ProjectController.groovy
Outdated
Show resolved
Hide resolved
rundeckapp/grails-app/controllers/rundeck/controllers/ProjectController.groovy
Outdated
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/library/components/plugins/pluginConfig.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
Plugin enhancement to define dynamic default values for plugin properties
Describe the solution you've implemented
It was added a
Map<String, Object> dynamicDefaults( Map<String, Object> projectAndFrameworkValues, Services services )method to the DynamicProperties interface.This method should return a map with string default values for all the dynamic properties
Additional context
Also updates project config save/update process to enforce more validation of plugin property values