Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSE-722 Fix: Expand Timeout Variable on Scheduled Job #8482

Merged
merged 5 commits into from Aug 10, 2023
Merged

Conversation

DarwisNarvaezDev
Copy link
Contributor

@DarwisNarvaezDev DarwisNarvaezDev commented Aug 8, 2023

RSE-722 Fix: Expand Timeout Variable on Scheduled Job

The 'timeout' variable wont get expanded when the job is triggered by a schedule.

The Problem

The timeout was taken literally from the DB.

The Solution

Expanding the variable programmatically as the 'user ran' process workflow.

To QA ✔️

  1. Create a job with an option named "timeout" and default value of 5 and
  2. A step which lasts 15 seconds then
  3. Go to "other" in job definition and input '${option.timeout}' in 'Timeout' field also
  4. Schedule it to run each minute and save the job

🏁 Expected behavior: the job fails in 5 seconds after the schedule triggers it.

@DarwisNarvaezDev DarwisNarvaezDev marked this pull request as draft August 8, 2023 21:02
@DarwisNarvaezDev DarwisNarvaezDev modified the milestone: 4.17.0 Aug 9, 2023
@DarwisNarvaezDev DarwisNarvaezDev marked this pull request as ready for review August 9, 2023 21:29
Copy link
Contributor

@alexander-variacode alexander-variacode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more test options like -1, null, 0

Copy link
Contributor

@alexander-variacode alexander-variacode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarwisNarvaezDev DarwisNarvaezDev added this to the 4.16.0 milestone Aug 10, 2023
@DarwisNarvaezDev DarwisNarvaezDev merged commit a3792e1 into main Aug 10, 2023
3 checks passed
@DarwisNarvaezDev DarwisNarvaezDev deleted the RSE-722 branch August 10, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants