Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUN-1346: Remove database storage for "Node Filters" #8558

Merged
merged 53 commits into from Nov 6, 2023
Merged

RUN-1346: Remove database storage for "Node Filters" #8558

merged 53 commits into from Nov 6, 2023

Conversation

gschueler
Copy link
Member

Is this a bugfix, or an enhancement? Please describe.
Removes the db-backed storage for stored Node filters, replaces it with browser local storage

Describe the solution you've implemented

  • Removes the db-backed storage for Node filters
  • Replaces GSP UI for node filters with the Vue component
    • Commands page
    • Nodes page
    • Job edit > workflow edit > job reference
    • Job show page
  • changes implementation for Node filters to use browser local storage

@gschueler gschueler mentioned this pull request Sep 20, 2023
Merged
2 tasks
@gschueler gschueler marked this pull request as ready for review September 21, 2023 22:49
@gschueler gschueler added this to the 4.18.0 milestone Sep 21, 2023
@gschueler gschueler changed the title RUN-1346: (wip) remove db storage for "node filters" RUN-1346: remove db storage for "node filters" Sep 25, 2023
@fdevans fdevans removed this from the 4.18.0 milestone Sep 28, 2023
@gschueler gschueler added this to the 5.0.0 milestone Sep 28, 2023
@gschueler
remove support for named node filters
edc8249
@gschueler
gsp: remove node filters
d79c4b9
@gschueler
remove node filters from user Model type
9874315
@gschueler
remove node filter domain class
3d2535a
@gschueler
remove node filter behavior from knockout/gsp front end code
9c40397
@gschueler
cleanup: unused
b876518
@gschueler
cleanup: unused
122c154
@gschueler
remove node filter name
c314626
@gschueler
fix: correctly pass filter name param
4039590
@gschueler
use local storage to manage node filters
639a0db
@gschueler
cleanup: remove unused
64fcb44
@gschueler
add i18n text
24e4b05
@gschueler
cleanup db migration for removed table
ea7c0cb
@gschueler
remove test for removed domain class
57d2ad6
@gschueler
remove unneeded wrapper span
e036ca0
@gschueler
define mutation observer that can add ui sockets to new dom nodes
d3394b9
@gschueler
use ui-socket mutation observer for workflow editor
5e5bdfd
@gschueler
remove filterName
76e9433
@gschueler
split selectNodeFilterLink to make it easier to call with data
85cde12
@gschueler
fix: filters should not always append
34707d7
@gschueler
fix: selector, a changed to button
702758f
@gschueler
remove job filters from rdUser datatype
9e59d10
@gschueler
remove job filters data from frontend and controllers
4d64e56
@gschueler
remove ScheduledExecutionFilter domain class
95fc10c
@gschueler
remove db migration for scheduled_execution_filter
ec987fe
@gschueler
remove saved job filters from GUI
6b1ff72
@gschueler
job filters: skip constraint unless table exists
ed1a625
@gschueler
remove event filter storage endpoints from controller
f104267
@gschueler
remove stored event filter urls
1ef84ad
@gschueler
add local storage for event filters
e2de1b5
@gschueler
don't pass filterName as query param
fc43427
@gschueler
use local storage for activity filters
680608f
@gschueler
update for new stored filter data type
6b58638
@gschueler
remove getReportFilters from RdUser interface
f81498b
@gschueler
remove: unused
216c6e0
@gschueler
remove db loading of report filters
8a930d4
@gschueler
remove ReportFilter domain class
bf140a3 
remove db migrations

db migration: remove report_filter
@gschueler
cleanup: wrong id
2c8b6ab
@gschueler
remove debugger
10c1cf3
@gschueler
update db migrations
0c955f8 
remove table setup (create,constraints) migrations for dropped tables
move the cleanup migrations to the last in the list
update
@gschueler
remove the tables that should not exist
2c08140
@gschueler
remove changeset for node_filter
89f439e
@gschueler
add validCheckSum
3aa4f96
carlosrfranco
carlosrfranco approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@carlosrfranco carlosrfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in:

  • Commands page
  • Nodes page
  • Job edit > workflow edit > job reference
  • Job show page
  • Starting app using an existent database to check migrations that were updated

@gschueler gschueler merged commit 6c402d4 into main Nov 6, 2023
3 checks passed
@gschueler gschueler deleted the RUN-1346 branch November 6, 2023 22:51
@smartinellibenedetti smartinellibenedetti mentioned this pull request Nov 24, 2023
Merged
@fdevans fdevans changed the title RUN-1346: remove db storage for "node filters" RUN-1346: Remove db storage for "node filters" Nov 28, 2023
@fdevans fdevans changed the title RUN-1346: Remove db storage for "node filters" RUN-1346: Remove database storage for "Node Filters" Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaveva ronaveva ronaveva left review comments

@carlosrfranco carlosrfranco carlosrfranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gschueler @carlosrfranco @ronaveva @fdevans