Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSE-792 Fix: No Indentation on JSON Resource Model Edit Page #8719

Merged
merged 9 commits into from Dec 20, 2023

Conversation

DarwisNarvaezDev
Copy link
Contributor

RSE-792 Fix: No Indentation on JSON Resource Model Edit Page

The text rendered as a single line if the resource model has JSON as language.

The Problem

The ace editor was receiving a single text through vue's watcher.

The Fix

Parsing first the text to JSON text in order to format properly the json required literals, then parsing the text into json to feed the ace editor with proper values.

馃弫 tested with others ace editor (vue) renderers as the node wizard functionality.

@DarwisNarvaezDev DarwisNarvaezDev marked this pull request as draft November 30, 2023 15:04
Copy link
Contributor

@alexander-variacode alexander-variacode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarwisNarvaezDev DarwisNarvaezDev merged commit c34e074 into main Dec 20, 2023
3 checks passed
@DarwisNarvaezDev DarwisNarvaezDev deleted the RSE-792 branch December 20, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants