RUN-2126: Bug/fix behavior when remotevalues reload #8793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschueler
changed the title
gschueler
approved these changes
Feb 7, 2024
|
@muehan thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed up this one: #8657
So here we go again.
Is this a bugfix, or an enhancement? Please describe.
Bugfix: #8587
Describe the solution you've implemented
cleanup if(remote()) function in jobOptions.
It now only showes the values loaded remote to not mixup values from previous remote calls
Describe alternatives you've considered
fix doublication check, but this would not fix the behavior that there are values from an old call.
Additional context
I dont wanted to push the 3000 files from the **/bin folders.