Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUN-2148: UI:Next: jobs list SCM status fixes #8814

Merged
merged 7 commits into from Feb 20, 2024

Conversation

gschueler
Copy link
Member

@gschueler gschueler commented Jan 11, 2024

Is this a bugfix, or an enhancement? Please describe.

Fix two issues with the SCM status shown in Jobs list (Next UI):

  • Error message from invalid configuration or lack of access credentials should be shown in GUI
  • SCM status shown for a job was incorrect in some cases

Fix one issue with Git plugin:

  • if no ssh key or password path is configured, the GUI should not show an error about not having access to the path

test setup:

Create a source repo that can be used for both Import or Export:

# create src git repo "gitrepo"
mkdir gitrepo
(cd gitrepo && git init --bare )
mkdir gitcheckout
git clone $PWD/gitrepo gitcheckout
cd gitcheckout
git commit --allow-empty -m 'first'
git push origin -u

configure SCM export/import in the project:

  • Base directory: (use a file path for scm export, such as `$RDECK_BASE/projects/$project/export)
  • git URL: file:///path/to/gitrepo
  • Base branch on: master
  • branch: master

To test misconfigured key access:

under Authentication section, add a SSH Key Storage Path that doesn't exist.

In the Job list gui (next UI) there should be a warning icon with a message about the error. (Compare to legacy UI)

if there is an error in scm config or missing access credentials, the error should be shown in the gui
…ror in gui

e.g. local file git access should not cause error because no key/password is necessary
@gschueler gschueler added this to the 5.2.0 milestone Jan 11, 2024
@gschueler gschueler changed the title UI:Next: jobs list SCM status fixes RUN-2148: UI:Next: jobs list SCM status fixes Jan 11, 2024
Copy link
Contributor

@smartinellibenedetti smartinellibenedetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix confirmed! Thank you for the instructions regarding how to set up SCM, as I wasn't aware that the project had this functionality.

Noted one tiny nit, but it's an optional fix. 🚀

@gschueler gschueler merged commit d16c9e0 into main Feb 20, 2024
3 checks passed
@gschueler gschueler deleted the enh/nextui-jobs-scm-status branch February 20, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants