New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUN-2094: UI:Next: Project list with lazy loading #8815
Merged
smartinellibenedetti
merged 23 commits into
main
from
RUN-2094-project-list-infinite-scroll
Feb 9, 2024
Merged
RUN-2094: UI:Next: Project list with lazy loading #8815
smartinellibenedetti
merged 23 commits into
main
from
RUN-2094-project-list-infinite-scroll
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartinellibenedetti
force-pushed
the
RUN-2094-project-list-infinite-scroll
branch
2 times, most recently
from
January 29, 2024 22:45
e7506a1
to
99cf6e4
Compare
smartinellibenedetti
changed the title
RUN-2094: UI:Next: Project list with infinite scroll
RUN-2094: UI:Next: Project list with lazy loading
Jan 29, 2024
smartinellibenedetti
force-pushed
the
RUN-2094-project-list-infinite-scroll
branch
from
January 30, 2024 17:39
99cf6e4
to
18c06cf
Compare
gschueler
requested changes
Feb 2, 2024
rundeckapp/grails-app/controllers/rundeck/controllers/ProjectController.groovy
Outdated
Show resolved
Hide resolved
rundeckapp/grails-app/controllers/rundeck/controllers/ProjectController.groovy
Outdated
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/home/HomeActionsMenu.vue
Outdated
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/home/HomeActionsMenu.vue
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/home/HomeCardList.vue
Outdated
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/home/HomeCardList.vue
Outdated
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/home/services/homeServices.ts
Show resolved
Hide resolved
smartinellibenedetti
force-pushed
the
RUN-2094-project-list-infinite-scroll
branch
2 times, most recently
from
February 6, 2024 15:27
b095d07
to
4b25618
Compare
gschueler
reviewed
Feb 6, 2024
rundeckapp/grails-app/controllers/rundeck/controllers/ProjectController.groovy
Outdated
Show resolved
Hide resolved
gschueler
requested changes
Feb 6, 2024
rundeckapp/grails-app/controllers/rundeck/controllers/ProjectController.groovy
Outdated
Show resolved
Hide resolved
smartinellibenedetti
force-pushed
the
RUN-2094-project-list-infinite-scroll
branch
from
February 6, 2024 22:58
d06ee8f
to
a4639ba
Compare
smartinellibenedetti
force-pushed
the
RUN-2094-project-list-infinite-scroll
branch
from
February 7, 2024 14:57
a4639ba
to
45bdd14
Compare
gschueler
approved these changes
Feb 7, 2024
smartinellibenedetti
deleted the
RUN-2094-project-list-infinite-scroll
branch
February 9, 2024 15:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
Convert project view (menu/home) to vue, replacing the table pagination with infinite scroll.
Functionality implemented:
TLDR (tech):
What is not implemented in this PR:
Describe the solution you've implemented
Additional context
Lighthouse report:
Before:
After:
Note: performance didn't have big gains as the main problem is some of the js files that haven't been deprecated yet.