RSE-955: Fix: Allow to update existing webhooks at project import #8892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jesus-Osuna-M
force-pushed
the
RSE-955-update-existing-webhooks-at-project-import-based-on-RSE-979
branch
from
de30cb0
to
bc75516
Compare
Jesus-Osuna-M
changed the title
Jesus-Osuna-M
force-pushed
the
RSE-955-update-existing-webhooks-at-project-import-based-on-RSE-979
branch
5 times, most recently
from
2f758f1
to
97a88d0
Compare
Jesus-Osuna-M
force-pushed
the
RSE-955-update-existing-webhooks-at-project-import-based-on-RSE-979
branch
3 times, most recently
from
1170ba0
to
9c79de9
Compare
Jesus-Osuna-M
force-pushed
the
RSE-955-update-existing-webhooks-at-project-import-based-on-RSE-979
branch
from
9c79de9
to
3f89805
Compare
Jesus-Osuna-M
deleted the
RSE-955-update-existing-webhooks-at-project-import-based-on-RSE-979
branch
fdevans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When exporting a project and then importing into another instance, the Project Import feature fails to import webhooks if they already exist in the current project. Consequently, the webhook definitions are not updated.
Expected Outcome: Rundeck should treat webhook as it treats jobs when imported.
Proposed Solution: If a Webhook is being imported and should update an existing Webhook use the same UUID when saving the updated Webhook, this small change allows Webhooks to be updated when exported and imported over itself. Also, a new option should be added when importing a project to allow users to keep the same webhook UUID or generate new ones. By making these changes the Webhooks would be handled in the same way jobs are handled when a Project is imported over itself.
To make ir work with rd-cli needs: rundeck/rundeck-cli#546