New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUN-2135: Convert project node sources page to Vue #8898
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you've done a great job with this ticket and figuring out what was needed to get the PluginConfig working.
I've labeled the comments to help to distinguish their intent and priority - chores and todo are blockers, the suggestions are not (but please consider doing them as well).
Also, I noticed that it's possible to save the form while having the cache delay field empty. Do you know if it was always like this? If yes, think that it would be a good improvement to address this, but don't think it has to be in this ticket if the codebase assumes that a lack of value means the cache delay is 30s.
Last but not least, if you'd like, can show you unit testing for vue with jest sometime next week. It's not a must do at this point, but it would be great if we start to add them before starting to work on the new UI.
Didn't check the selenium test yet, but will do first thing next week.
...rails-spa/packages/ui-trellis/src/app/pages/project-nodes-config/ProjectConfigurableForm.vue
Outdated
Show resolved
Hide resolved
...rails-spa/packages/ui-trellis/src/app/pages/project-nodes-config/ProjectConfigurableForm.vue
Outdated
Show resolved
Hide resolved
...rails-spa/packages/ui-trellis/src/app/pages/project-nodes-config/ProjectConfigurableForm.vue
Outdated
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/pages/project-nodes-config/nodeSourcesUtil.ts
Outdated
Show resolved
Hide resolved
...rails-spa/packages/ui-trellis/src/app/pages/project-nodes-config/ProjectConfigurableForm.vue
Outdated
Show resolved
Hide resolved
...app/grails-spa/packages/ui-trellis/src/app/pages/project-nodes-config/ProjectNodeSources.vue
Outdated
Show resolved
Hide resolved
...app/grails-spa/packages/ui-trellis/src/app/pages/project-nodes-config/ProjectNodeSources.vue
Outdated
Show resolved
Hide resolved
...rails-spa/packages/ui-trellis/src/app/pages/project-nodes-config/ProjectConfigurableForm.vue
Outdated
Show resolved
Hide resolved
...rails-spa/packages/ui-trellis/src/app/pages/project-nodes-config/ProjectConfigurableForm.vue
Outdated
Show resolved
Hide resolved
...rails-spa/packages/ui-trellis/src/app/pages/project-nodes-config/ProjectConfigurableForm.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one last comment, but otherwise is g2g! Thanks for making these changes 🚀
Convert project node sources page to vue, converting the current project configurable template to vue as well