Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUN-2135: Convert project node sources page to Vue #8898

Merged
merged 17 commits into from Feb 26, 2024
Merged

RUN-2135: Convert project node sources page to Vue #8898

merged 17 commits into from Feb 26, 2024

Conversation

chrismcg14
Copy link
Contributor

@chrismcg14 chrismcg14 commented Feb 8, 2024

Convert project node sources page to vue, converting the current project configurable template to vue as well

@chrismcg14 chrismcg14 marked this pull request as draft February 8, 2024 23:31
@chrismcg14 chrismcg14 marked this pull request as ready for review February 9, 2024 02:09
Copy link
Contributor

@smartinellibenedetti smartinellibenedetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've done a great job with this ticket and figuring out what was needed to get the PluginConfig working.

I've labeled the comments to help to distinguish their intent and priority - chores and todo are blockers, the suggestions are not (but please consider doing them as well).

Also, I noticed that it's possible to save the form while having the cache delay field empty. Do you know if it was always like this? If yes, think that it would be a good improvement to address this, but don't think it has to be in this ticket if the codebase assumes that a lack of value means the cache delay is 30s.

Last but not least, if you'd like, can show you unit testing for vue with jest sometime next week. It's not a must do at this point, but it would be great if we start to add them before starting to work on the new UI.

Didn't check the selenium test yet, but will do first thing next week.

@chrismcg14 chrismcg14 added this to the 5.2.0 milestone Feb 20, 2024
Copy link
Contributor

@smartinellibenedetti smartinellibenedetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one last comment, but otherwise is g2g! Thanks for making these changes 🚀

@chrismcg14 chrismcg14 merged commit ac4af5c into main Feb 26, 2024
3 checks passed
@chrismcg14 chrismcg14 deleted the RUN-2135 branch February 26, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants