RUN-551: Vue conversion of job option editor #8922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you for tackling this piece of the conversion, it was huge!
From the FE perspective, I tested the following:
- creating new options with all the input types (it's working);
- editing and saving (it's not working 100% due to data mismatches);
- duplicating the options (working fine, but if you duplicate an option that UI isn't handling correctly, the duplicate will have the same issues)
- changing the order of options by clicking the arrows/drag and drop (working 100%)
- downloading and uploading the job definition (working, tested json and yaml)
- saving a job that has a schedule with options with missing properties (working)
- undo & redo (working)
Majority of my comments are small nits/things that can be done at a later time, but marked as blockers the ones that might be confusing/problematic for the users (I got myself confused a few times until realizing what was going on).
Also, is it intentional to have the whole object output in the top error message?
rundeckapp/grails-app/controllers/rundeck/controllers/EditOptsController.groovy
Outdated
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/utilities/locales/en_US.js
Outdated
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/job/options/OptionEdit.vue
Outdated
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/job/options/OptionEdit.vue
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/job/options/OptionEdit.vue
Outdated
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/job/options/OptionEdit.vue
Outdated
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/job/options/OptionEdit.vue
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/job/options/OptionView.vue
Outdated
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/job/options/OptionView.vue
Outdated
Show resolved
Hide resolved
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/job/options/OptionEdit.vue
Outdated
Show resolved
Hide resolved
smartinellibenedetti
approved these changes
Mar 18, 2024
rundeckapp/grails-spa/packages/ui-trellis/src/app/components/job/options/OptionEdit.vue
Show resolved
Hide resolved
gschueler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
Vue conversion of Job Option edit section