Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSE-1043: Improve test "click on gutter and refresh should highlight correct line" #8970

Conversation

Jesus-Osuna-M
Copy link
Contributor

@Jesus-Osuna-M Jesus-Osuna-M commented Mar 1, 2024

This PR addresses a failure in the automated test "click on gutter and refresh should highlight correct line". The test originally designed to verify the ability to highlight the correct line upon clicking on the gutter and refreshing the page exhibited inconsistent behavior on cicleCI.

Changes Made:
Modified the test logic to ensure that the correct line is reliably highlighted after refreshing the page.
Improved element waiting in the test to handle potential delays in page loading.
Import an existing job to avoid UI interaction

@Jesus-Osuna-M Jesus-Osuna-M added this to the 5.2.0 milestone Mar 1, 2024
@Jesus-Osuna-M Jesus-Osuna-M marked this pull request as ready for review March 1, 2024 13:31
Copy link
Contributor

@DarwisNarvaezDev DarwisNarvaezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be explicit about the step you took to improve the test in PR's description.

@Jesus-Osuna-M Jesus-Osuna-M force-pushed the RSE-1043-improve-test-click-on-gutter-and-refresh-should-highlight-correct-line branch from 8d7d24b to f50d1f6 Compare March 2, 2024 00:56
Copy link
Contributor

@DarwisNarvaezDev DarwisNarvaezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jesus-Osuna-M Jesus-Osuna-M merged commit 28673e4 into main Mar 4, 2024
3 checks passed
@Jesus-Osuna-M Jesus-Osuna-M deleted the RSE-1043-improve-test-click-on-gutter-and-refresh-should-highlight-correct-line branch March 4, 2024 13:03
@fdevans fdevans changed the title RSE-1043 Improve test "click on gutter and refresh should highlight correct line" RSE-1043: Improve test "click on gutter and refresh should highlight correct line" Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants