RSE-873: Scheduled forecast GUI errors #8998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelasquezr
force-pushed
the
RSE-873-scheduled-forecast-gui-errors
branch
2 times, most recently
from
72badad
to
664d668
Compare
ronaveva
reviewed
Mar 13, 2024
functional-test/src/test/groovy/org/rundeck/util/container/BaseContainer.groovy
Outdated
Show resolved
Hide resolved
ronaveva
reviewed
Mar 13, 2024
rundeckapp/src/test/groovy/rundeck/controllers/MenuControllerSpec.groovy
Outdated
Show resolved
Hide resolved
ronaveva
reviewed
Mar 13, 2024
rundeckapp/src/test/groovy/rundeck/interceptors/ApiProjectSelectInterceptorSpec.groovy
Show resolved
Hide resolved
ronaveva
reviewed
Mar 13, 2024
rundeckapp/grails-app/controllers/rundeck/controllers/MenuController.groovy
Outdated
Show resolved
Hide resolved
ronaveva
reviewed
Mar 13, 2024
functional-test/src/test/groovy/org/rundeck/util/gui/pages/BasePage.groovy
Show resolved
Hide resolved
RSE-873-scheduled-forecast-gui-errors
Update BasePage.groovy Fix tests with new sleep
avelasquezr
force-pushed
the
RSE-873-scheduled-forecast-gui-errors
branch
from
23b2426
to
799ee5a
Compare
1) change disableScheduledAndDeleteProject method to receive params 2) change api version to the last version. 3) the original test is added in the where and if it matches with false. Additional: Add groovy docs Update ProjectUtils.groovy
avelasquezr
force-pushed
the
RSE-873-scheduled-forecast-gui-errors
branch
from
9ff71be
to
bcc68a2
Compare
ronaveva
reviewed
Mar 13, 2024
functional-test/src/test/groovy/org/rundeck/util/container/BaseContainer.groovy
Outdated
Show resolved
Hide resolved
Refactor code. Separate in two method to update configuration project and delete project
avelasquezr
force-pushed
the
RSE-873-scheduled-forecast-gui-errors
branch
from
3561319
to
a5af02e
Compare
avelasquezr
force-pushed
the
RSE-873-scheduled-forecast-gui-errors
branch
from
93b4fb5
to
411654e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
This PR addresses a bug related to the Schedule Forecast page.
Describe the problem
When selecting more than two projects (but not all) on the Schedule Forecast page and clicking the "search" button, the loading icon remains stuck, and a warning icon appears. This issue stems from the API call to
http://rundeck/api/v/{params.project}/executions/runningwhereparams.projectis not correctly processed for multiple selected projects.Describe the solution you've implemented
The solution involves two main changes:
ApiProjectSelectInterceptorto include an exclusion for theapiExecutionsRunningv14()method, allowing it to bypass pre-validation checks that incorrectly handle multiple projects.apiExecutionsRunningv14()method will be updated to:params.projectstring by commas to process each project individually.Describe alternatives you've considered
An alternative approach was to refactor the interceptor validations. However, this would have required significant changes across various API calls and potentially introduced new bugs. The chosen solution minimizes the impact on other components and focuses on addressing the specific issue.
References
fixes #RSE-873