-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUN-2525: Update storybook and style components to match continuum #9040
Open
smartinellibenedetti
wants to merge
15
commits into
main
Choose a base branch
from
hackweek-storybook
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18,573
−20,977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartinellibenedetti
force-pushed
the
hackweek-storybook
branch
from
May 23, 2024 14:31
9867e0e
to
c58992c
Compare
smartinellibenedetti
force-pushed
the
hackweek-storybook
branch
from
May 23, 2024 23:55
5957c2f
to
1363560
Compare
smartinellibenedetti
added
release-notes/exclude
(excludes issue from generated release notes)
to-jira
and removed
to-jira
labels
May 23, 2024
smartinellibenedetti
changed the title
[HACKWEEK] Update storybook and style components to match continuum
RUN-2525: Update storybook and style components to match continuum
May 23, 2024
gschueler
reviewed
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got an error in the storybook UI: Cannot find module './storybook.css'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work for storybook - updates it to the latest version and get some components styled. As per the to do list, there are more work to be done, but will be adding in a series of separated PRs as work progresses (and QA gets done by designers).
To do:
Style and document the following components:
To run storybook:
npm run storybook