RUN-2260: Fix: spinner always shown in nextUi jobs list #9045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invert spinner loading property semantics hide spinner by default
smartinellibenedetti
approved these changes
Apr 4, 2024
| it("no content if there is no scm status", async () => { | ||
| const wrapper = await mountJobScmStatus({ itemData: {} }); | ||
|
|
||
| let detail = wrapper.findAll("*"); |
There was a problem hiding this comment.
question: why you're searching for an asterisk here?
There was a problem hiding this comment.
css selector for any element, expecting to find nothing in this case
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
gschueler
added a commit
that referenced
this pull request
Apr 5, 2024
[release/5.2.x] Merge pull request #9045 from rundeck/RUN-2260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
Fix: SCM status spinner is always shown for jobs in the next UI job list screen
Describe the solution you've implemented
Describe alternatives you've considered
Additional context