RUN-2450: fix config for detectFirstrun #9118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move to MenuService, define SystemConfigurable
mrdubr
approved these changes
May 17, 2024
| boolean shouldShowFirstRunInfo(){ | ||
| boolean isFirstRun = false | ||
| if(configurationService.getBoolean(MenuService.SYS_CONFIG_DETECT_FIRST_RUN, true) && | ||
| frameworkService.rundeckFramework.getPropertyLookup().hasProperty('framework.var.dir')) { |
There was a problem hiding this comment.
woah... one busy method! :-)
Would it make sense to synchronize this method given that it may result in a race condition when two requests are made to the controller endpoint?
There was a problem hiding this comment.
I think it's not necessary, if the race causes two or more requests to think the file doesn't exist, then worst case is that multiple users see the splash screen
There was a problem hiding this comment.
arguably, this splash screen mechanism isn't very good because only 1 user would normally see it anyway.
gschueler
commented
May 17, 2024
rundeckapp/src/test/groovy/rundeck/controllers/MenuControllerSpec.groovy
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
Fixes the
rundeck.startup.detectFirstRunconfig flag to work, enables setting it via remco.Describe the solution you've implemented
Describe alternatives you've considered
Additional context