Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DATA-586] Fix **parameters comment & imports #32

Merged
merged 4 commits into from
Dec 2, 2022
Merged

[DATA-586] Fix **parameters comment & imports #32

merged 4 commits into from
Dec 2, 2022

Conversation

abhinavpottabathula
Copy link
Contributor

@abhinavpottabathula abhinavpottabathula commented Dec 2, 2022 •
edited

Jira Ticket

Note: I added an additional minor import change to this PR since it was quick. Essentially this import structure was erroring:

from runeq import initialize
initialize()

from runeq import resources
patients = resources.patient.get_all_patients()
print(patients.to_list())

with

    patients = resources.patient.get_all_patients()
AttributeError: module 'runeq.resources' has no attribute 'patient'

I figured it would be more flexible to support these import structures as well.

@abhinavpottabathula abhinavpottabathula changed the title [DATA-586] Documentation Fix **parameters comments [DATA-586] Fix **parameters comment & imports Dec 2, 2022
cranti
cranti reviewed Dec 2, 2022
View reviewed changes
tests/resources/test_client.py
@@ -34,7 +34,10 @@ def test_init_with_access_keys(self):
access_token_secret="bar",
)

with self.assertRaisesRegex(errors.APIError, "404 NotFound"):
with self.assertRaisesRegex(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It changed to become what it should have been in the first place actually haha, thanks to artichoke!

AssertionError: "404 NotFound" does not match "401 InvalidAuthentication: {'message': 'Invalid artichoke authentication', 'type': 'InvalidAuthentication'}"

cranti
cranti approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@cranti cranti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhinavpottabathula abhinavpottabathula merged commit 283bc9d into main Dec 2, 2022
@cranti cranti deleted the params_doc branch December 2, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cranti cranti cranti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abhinavpottabathula @cranti