Add to_dataframe to ItemSet; support datetime.datetime #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmora
reviewed
Aug 11, 2023
|
|
||
| def to_dataframe(self) -> pd.DataFrame: | ||
| """Convert items to a dataframe (wraps `to_list()`)""" | ||
| return pd.DataFrame(self.to_list()) |
There was a problem hiding this comment.
Does this work without using a keyword arg? I would expect this to error if called: https://github.com/pandas-dev/pandas/blob/v2.0.3/pandas/core/frame.py#L643
There was a problem hiding this comment.
it does! Python is permissive...
>>> def func(a=None, b=None):
... print(a, b)
...
>>> func('hello')
hello None
>>> func('hello', 'world')
hello world
>>> func(b='hello', a='world')
world hello
There was a problem hiding this comment.
Huh. I guess it's just putting non kwargs after kwargs that it doesn't like!
cranti
force-pushed
the
sw-2247/datetime
branch
from
3a388da
to
9930cb4
Compare
maxmora
approved these changes
Aug 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor improvements:
ItemSetclass, to create a pandas dataframe representing the items in the setdatetime.datetimeas an input forget_stream_dataandget_stream_availability. These functions currently acceptdatetime.date, which only has precision to the day.