Formatting misfire with anything following item macro call

[udoprog]

See: https://github.com/rune-rs/rune/actions/runs/5084802670/jobs/9137546952?pr=526#step:4:590

[udoprog]

It seems like anything following the macro call gets munched, even if it's a comment or a use.

[tgolsson]

Is there just a missing \n? Or more destructive?

[udoprog]

It chomps away all newlines (one per fmt call) until there's no separation at all between items.

[tgolsson]

I think this invocation needs to add a newline:

rune/crates/rune/src/fmt/printer.rs

Lines 687 to 689 in ca44d50

	if let Some(semi) = semi {
	self.writer.write_spanned_raw(semi.span, false, false)?;
	}

So true, false as the whitespace args. Super-busy at the moment but might have some time to look more in-depth during the weekend.

[udoprog]

No worries. Just thought you'd be interested! Take your time or if you want, I can look into it.

[tgolsson]

Hmm, running locally I hit

error: Compile error
  ┌─ scripts/make_function.rn:3:5
  │
3 │     make_function!(inner_fn => { "Hello World Again!" });
  │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Missing macro `make_function`

on latest main.
Using the same command as CI; cargo run --bin rune -- fmt --experimental --recursive --verbose --workspace --check tools scripts

[tgolsson]

Looks to be lookup order, though if I switch the import to the top it fails on the macro evaluation.

[udoprog]

Item expansion inside of functions has also* been temporarily disabled until I can figure out how to make it less messy. Try with the current version I just pushed.

I also have a pretty bad cold, so I might be checked out for a few more days.

[udoprog]

Closed in #539