-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update for lmertest models fails when inside a function #3
Comments
Argh, managing how things are evaluated in various environments is not exactly my favourite activity! But thanks for the bug report! It should be fixed now in the
Cheers |
Thanks so much, that works for me as well. And I completely agree. Evaluation in different environments is a never ending source of bugs and problems. I believe I once read a rant by Ben Bolker on R-devel where he suggested to source for all this is the way One more thing. Do you have a concrete plan when to submit to CRAN? I am about to (after running the reverse dependency checks once more), but still get a note with the current CRAN version of |
Okay, that was a little premature celebration. Now I get a bug in the |
Got the bug:
|
Thanks, I'll have a look.
…On 31 March 2018 at 11:28, Henrik Singmann ***@***.***> wrote:
Got the bug:
library("lme4")
myfit <- function(formula, data) {
lme4::lmer(formula = formula, data = data)
}
fm2 <- myfit(Reaction ~ Days + (Days|Subject), sleepstudy)
lmerTest::as_lmerModLmerTest(fm2)
# Error in if (!is.function(devfun) || names(formals(devfun)[1]) != "theta") stop("Unable to extract deviance function from model fit") :
# missing value where TRUE/FALSE needed
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE-crW8ZpTu-AQlSQyteDCXc-AJ3QlKOks5tj0w1gaJpZM4TBphN>
.
|
Hmm. Looking at this, I am beginning to doubt that this is ever going to work... I don't see how any function outside of
But maybe I've gone blind and lost in the "environmental maze"... If, instead, we move the call to
Anyway, long story short: if you could point me to when and where you see the problem in afex, I'll be happy to take a look at afex+lmerTest (I think at this point I would like to be able to reproduce the original problem myself). Cheers |
Actually, the only problem I see when I check afex is
but if you use Cheers |
Hi Rune, Sorry for the delay (I was travelling today) and this indeed appears to be my error. When I test it now again, the tests run fine. So the only question open for me is now when to submit or not. Let me know if you have any concrete plans, but I will nevertheless close the issue now. Cheers, |
Hi Henrik, Thanks for the feedback. The plan is to submit the new lmerTest "3 weeks from the date of [the] email" which notified maintainers so about March 15th. I see an additional 3 packages no longer failing checks with the newest version of afex, so in a way it would be nice to have the new version of afex on CRAN for the other packages to lean on. If you would rather hold the CRAN submission until ~March 15th (and potentially Cheers |
fix Eval update in functions (fixes #3)
Hi Rune,
While preparing the necessary fixes for the new
lmerTest
version forafex
I noticed that one set of tests fails due to an apparent bug inlmertest
.update
does not work inside a function when passed an additional data argument.As long as this is the case, my
all_fit
function fails and this crashes quite a few tests.The text was updated successfully, but these errors were encountered: