Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Time Tracker does not update with the client time tracking information due to captial letter in username #362

Closed
tikeyike opened this issue Sep 25, 2020 · 5 comments · Fixed by #364
Assignees
Labels

Comments

@tikeyike
Copy link

Describe the bug
When you log into runescape using an account name that contains capital letters — the time tracking information in the client never gets updated on the RuneLite website because it looks like the username is case senstive — it shows up all in lowercase letters on the RuneLite website (refer to screenshot below), even when I log in with capital letters in my username.

To Reproduce
Steps to reproduce the behaviour:

  1. Login with a username using at least 1 capital letter (e.g. Big Chungus) — alternatively, change the settings.properties name for any of the time tracking settings e.g. timetracking.Big\ Chungus.11317.4771=212\:1583435890
  2. Make sure if you are editing the settings.properties file, import it so it syncs with your RuneLite account.
  3. Log into the RuneLite website with the same email address that you used to log into the client
  4. Head over to the time tracking section, and make sure you select the correct account.
  5. Try refreshing the page to show the time tracking information from the RuneLite client.
  6. See that it never updates the information on the website.

Expected behaviour
A clear and concise description of what you expected to happen.

The expected behaviour is if I log in with a username for my runescape account e.g. Big Chungus, it should recognise the capital letters in the time tracking settings in the settings.properties

Screenshots
If applicable, add screenshots to help explain your problem.

image

**Note: that big chungus is lowercase here, even when logging in using Big Chungus

Environment (please complete the following information):

  • OS: Windows
  • RuneLite version: 1.6.27
  • Launcher version: 2.1.3

Additional context
Here is what shows up in my settings.properties when logging in with a username that contains a capital letter (I replaced my username with Big Chungus for security/privacy reasons — the results is the same either way)

timetracking.activeTab=HERB
timetracking.birdHouseNotification=true
timetracking.defaultTimerMinutes=5
timetracking.estimateRelative=true
timetracking.farmingContractInfoBox=true
timetracking.Big\ Chungus.10288.4771=0\:1600999673
timetracking.Big\ Chungus.10548.4771=60\:1601004075
timetracking.Big\ Chungus.10548.4772=60\:1601004075
timetracking.Big\ Chungus.10548.4773=41\:1601004075
timetracking.Big\ Chungus.10548.4774=32\:1601004100
timetracking.Big\ Chungus.11062.4771=60\:1601004113
timetracking.Big\ Chungus.11062.4772=60\:1601004113
timetracking.Big\ Chungus.11062.4773=41\:1601004113
timetracking.Big\ Chungus.11062.4774=32\:1601004149
timetracking.Big\ Chungus.11321.4771=32\:1601003934
timetracking.Big\ Chungus.11325.4771=32\:1601003782
timetracking.Big\ Chungus.12083.4771=60\:1601004040
timetracking.Big\ Chungus.12083.4772=60\:1601004040
timetracking.Big\ Chungus.12083.4773=41\:1601004040
timetracking.Big\ Chungus.12083.4774=32\:1601004064
timetracking.Big\ Chungus.12854.4771=60\:1600999715
timetracking.Big\ Chungus.14391.4771=60\:1601003953
timetracking.Big\ Chungus.14391.4772=60\:1601003953
timetracking.Big\ Chungus.14391.4773=41\:1601003953
timetracking.Big\ Chungus.14391.4774=32\:1601003985
timetracking.Big\ Chungus.4922.4771=0\:1601031972
timetracking.Big\ Chungus.4922.4772=50\:1601031972
timetracking.Big\ Chungus.4922.4773=0\:1601031972
timetracking.Big\ Chungus.4922.4774=0\:1601031972
timetracking.Big\ Chungus.4922.4775=36\:1601031972
timetracking.Big\ Chungus.4922.7904=45\:1601031972
timetracking.Big\ Chungus.4922.7905=61\:1601031972
timetracking.Big\ Chungus.4922.7906=41\:1601031972
timetracking.Big\ Chungus.4922.7907=0\:1601031972
timetracking.Big\ Chungus.4922.7909=0\:1601031972
timetracking.Big\ Chungus.4922.7910=0\:1601031972
timetracking.Big\ Chungus.4922.7911=0\:1601031972
timetracking.Big\ Chungus.6967.4771=60\:1601003999
timetracking.Big\ Chungus.6967.4772=60\:1601003999
timetracking.Big\ Chungus.6967.4773=41\:1601003999
timetracking.Big\ Chungus.6967.4774=32\:1601004030
timetracking.Big\ Chungus.autoweed=0
timetracking.sortOrder=NONE
timetracking.timeFormatMode=RELATIVE
timetracking.timerNotification=true
timetracking.timerWarningThreshold=10
@tikeyike
Copy link
Author

Let me know if you need more information — happy to assist.

Cheers,

@Adam- Adam- added the bug label Sep 25, 2020
@Adam- Adam- transferred this issue from runelite/runelite Sep 25, 2020
deathbeam added a commit to deathbeam/runelite.net that referenced this issue Sep 27, 2020
As usernames are case insensitive (and rest of the configs as far as
site is related are as well), lowercase config all keys when fetching
configuration.

Closes runelite#362

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
deathbeam added a commit to deathbeam/runelite.net that referenced this issue Sep 27, 2020
As usernames are case insensitive (and rest of the configs are as well on the site), lowercase config all keys when fetching
configuration.

Closes runelite#362

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
@deathbeam
Copy link
Member

@tikeyike
Copy link
Author

I logged into my RuneLite account on your preview website.
I logged into the RuneLite client using my RSN using a capital letter e.g. Big Chungus

This is a screenshot of my time tracker on the client (as of creating this reply):
image

This is what I see on the preview RuneLite website (as of creating this reply):
image

Note: If I log in using big chungus instead of Big Chungus — it works as expected — it's only when there is a capital letter (I believe) that breaks it. I believe the config for the time tracker stores usernames in lowercase letters. After talking with some people on Discord — the consensus is that having a capital letter in your username is the cause of this issue.

@deathbeam
Copy link
Member

Hmm so do you have config stored for both lowercase and normal cased version of your username? In the preview website I solved the casing issue by making all config lowercase, but looks like in your screenshot it still picked up something else. Rs usernames are case insensitive and to avoid displaying x amount of entries in account selection I lowercase them all before listing them to avoid duplicates. But if you have stored data for both lowercase version of your username and normal cased version, I really dont know which oen should site use.

@tikeyike
Copy link
Author

Ahh yes, you're right — I had config for both lowercase and normal cased versions of my username. I remove all those time tracking config from my settings.properties file (and synced it again) and logged in using my normal case version of my username — and it worked!

Looks like you did fix it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants