-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website Time Tracker does not update with the client time tracking information due to captial letter in username #362
Comments
Let me know if you need more information — happy to assist. Cheers, |
As usernames are case insensitive (and rest of the configs as far as site is related are as well), lowercase config all keys when fetching configuration. Closes runelite#362 Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
As usernames are case insensitive (and rest of the configs are as well on the site), lowercase config all keys when fetching configuration. Closes runelite#362 Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
Can you test this @tikeyike https://deploy-preview-364--runelite.netlify.app/? |
Hmm so do you have config stored for both lowercase and normal cased version of your username? In the preview website I solved the casing issue by making all config lowercase, but looks like in your screenshot it still picked up something else. Rs usernames are case insensitive and to avoid displaying x amount of entries in account selection I lowercase them all before listing them to avoid duplicates. But if you have stored data for both lowercase version of your username and normal cased version, I really dont know which oen should site use. |
Ahh yes, you're right — I had config for both lowercase and normal cased versions of my username. I remove all those time tracking config from my Looks like you did fix it 😄 |
Describe the bug
When you log into runescape using an account name that contains capital letters — the time tracking information in the client never gets updated on the RuneLite website because it looks like the username is case senstive — it shows up all in lowercase letters on the RuneLite website (refer to screenshot below), even when I log in with capital letters in my username.
To Reproduce
Steps to reproduce the behaviour:
timetracking.Big\ Chungus.11317.4771=212\:1583435890
settings.properties
file, import it so it syncs with your RuneLite account.Expected behaviour
A clear and concise description of what you expected to happen.
The expected behaviour is if I log in with a username for my runescape account e.g. Big Chungus, it should recognise the capital letters in the time tracking settings in the
settings.properties
Screenshots
If applicable, add screenshots to help explain your problem.
**Note: that
big chungus
is lowercase here, even when logging in usingBig Chungus
Environment (please complete the following information):
Additional context
Here is what shows up in my
settings.properties
when logging in with a username that contains a capital letter (I replaced my username with Big Chungus for security/privacy reasons — the results is the same either way)The text was updated successfully, but these errors were encountered: