Update UI to use BorderLayout, fixes resizeable issues #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adam-
reviewed
Apr 12, 2017
| private ClientPanel panel; | ||
| private NavigationPanel navigationPanel; | ||
| private PluginPanel pluginPanel; | ||
| private boolean expanded; | ||
| private int collapsedWidth = ClientPanel.PANEL_WIDTH + NavigationPanel.PANEL_WIDTH; | ||
| private int expandedWidth = collapsedWidth + PluginPanel.PANEL_WIDTH; |
There was a problem hiding this comment.
These two fields seem constant, should be static final
|
This seems to move the nav bar to be on the left side of the plugin area instead of the right side, which I don't want. |
|
And do you want the ClientPanel to change size when opening and closing the PluginPanel? |
|
@RobinWeymans I will eventually revisit the entire UI but for now it works well enough. |
|
Had to modify this to slightly to make it not resize the height down smaller than the panel height (I don't know why) when closing the side panel... Otherwise seems to work, merged. |
Closed
FrostyFridge
added a commit
to FrostyFridge/runelite
that referenced
this pull request
Mar 16, 2019
Update to new RL api for new game version
Jacoblairm
pushed a commit
to Jacoblairm/runelite
that referenced
this pull request
Jun 2, 2019
UKMonster
pushed a commit
to UKMonster/microbot
that referenced
this pull request
Sep 11, 2023
Blast Furnace in the works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.