clientui: apply custom borders when maximizing #17529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the window is made visible, window state change events aren't guaranteed to be fired. This causes RuneLite's custom window chrome borders to not be removed when restoring a maximized window on client startup. It's fixed by manually reapplying borders when restoring the maximized window state for the "Remember client position" setting. The state change event not being guaranteed is mentioned here: https://docs.oracle.com/en/java/javase/11/docs/api/java.desktop/java/awt/Frame.html#setExtendedState(int)
|
Here's a clip of the issue, first on runelite master, then with this PR. Thanks to @Jin-Jiyunsun fixed.mp4 |
|
Closes #17499 |
|
How do we apply fix for this issue? doesn't seem to be working for me yet? |
It will be fixed when the next version of RuneLite comes out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the window is made visible, window state change events aren't guaranteed to be fired. This causes RuneLite's custom window chrome borders to not be removed when restoring a maximized window on client startup. It's fixed by manually reapplying borders when restoring the maximized window state for the "Remember client position" setting.
The state change event not being guaranteed when the window isn't visible is mentioned here: https://docs.oracle.com/en/java/javase/11/docs/api/java.desktop/java/awt/Frame.html#setExtendedState(int)
I couldn't find any open issues about this.Closes #17499