Add kc command #4067
Add kc command #4067
Conversation
| { | ||
| if (!response.isSuccessful()) | ||
| { | ||
| throw new IOException("Unable to look up killcount!"); |
There was a problem hiding this comment.
I would probably just return 0 here, maybe.
There was a problem hiding this comment.
I disagree, a 0 is different to "I couldn't get a value" - Though I would update the usage of this on ChatCommandPlugin:290 so that when the IOException is thrown, it lets the user know in their chatbox, rather than, from a user perspective, failing silently.
| @Value | ||
| class KillCountKey | ||
| { | ||
| String username; |
There was a problem hiding this comment.
Access modifiers? private final maybe. Even though lombok generates most, i am not sure, I think this should still have some
There was a problem hiding this comment.
@Value will generate all fields as private final.
There was a problem hiding this comment.
I would make this private final anyway as that is how we do it at other places and this could just throw false warnings in IDE.
|
|
||
| String response = new ChatMessageBuilder() |
| } | ||
| catch (IOException ex) | ||
| { | ||
| log.debug("unable to lookup killcount", ex); |
There was a problem hiding this comment.
I would probably use 0 here, maybe. Not sure how we handle such cases with !price commands
|
|
||
| private void killCountLookup(ChatMessageType type, SetMessage setMessage, String search) | ||
| { | ||
| String player; |
| player = sanitize(setMessage.getName()); | ||
| } | ||
|
|
||
| int kc; |
|
|
||
| String boss = value.substring(4); | ||
|
|
||
| int kc = getKc(boss); |
|
|
||
| chatboxInput.setStop(true); | ||
|
|
||
| String boss = value.substring(4); |
| @Subscribe | ||
| public void onChatboxInput(ChatboxInput chatboxInput) | ||
| { | ||
| String value = chatboxInput.getValue(); |
| } | ||
| } | ||
|
|
||
| public void sendChatboxInput(int chatType, String input) |
There was a problem hiding this comment.
I would probably make this something like continueWithMessage so we will not have public API for sending messages to server
| int kc; | ||
| try | ||
| { | ||
| kc = killCountClient.get(player, search); |
There was a problem hiding this comment.
The UX of this means that if an IOException occurs the user gets no feedback without checking their logs - Could we not present the user with a nicely formatted "Something went wrong" message?
| { | ||
| private final String value; | ||
| private final int chatType; | ||
| protected boolean stop; |
There was a problem hiding this comment.
Does this need to be protected? private seems fine
|
|
||
| case "dusk": | ||
| case "dawn": | ||
| case "galio": |
There was a problem hiding this comment.
even though this is funny, I dont think we should use this. Galio is reference to League of Legends character that is big gargoyle
| case "gargs": | ||
| return "Grotesque Guardians"; | ||
|
|
||
| case "archaeologist": |
There was a problem hiding this comment.
I would add also "crazy arch" here
| case "sire": | ||
| return "Abyssal Sire"; | ||
|
|
||
| case "smoke devil": |
There was a problem hiding this comment.
"thermy" is another very common abbreviation
| case "kril": | ||
| case "kril trutsaroth": | ||
| return "K'ril Tsutsaroth"; | ||
| case "arma": |
| final int kc = getKc(boss); | ||
| if (kc <= 0) | ||
| { | ||
| chatMessageManager.queue(QueuedMessage.builder() |
There was a problem hiding this comment.
I dont agree with not resuming the message and simply not sending them to other players. 1. that would look weird, when player sent some message to chat but nothing got displayed on other side 2. we dont do this in any other command and we just simply send it and display error message to everyone
| } | ||
| catch (Exception ex) | ||
| { | ||
| log.warn("unable to submit killcount", ex); |
| @Value | ||
| class KillCountKey | ||
| { | ||
| String username; |
There was a problem hiding this comment.
I would make this private final anyway as that is how we do it at other places and this could just throw false warnings in IDE.
| public void resume() | ||
| { | ||
| if (resumed) | ||
| return; |
| } | ||
| } | ||
|
|
||
| private void sendChatboxInput(int chatType, String input) |
There was a problem hiding this comment.
This method can be called from different thread, maybe make it synchronized or sending volatile? Or event post it to clientThread, maybe
Adam-
force-pushed
the
kc
branch
4 times, most recently
from
16e487e
to
64eca2e
Compare
No description provided.